Отчистика кода

Pf2eViewer/EntityConventor.cs

@@ -1,12 +1,9 @@
 using Microsoft.EntityFrameworkCore;
-using Microsoft.Extensions.Logging;
 using Newtonsoft.Json;
 using Newtonsoft.Json.Linq;
-using Pf2eModel;
 using Pf2eModel.Model;
 using Pf2eModel.Model.Base;
 using Pf2eModel.Model.Structure;
-using Processor = System.Func<Newtonsoft.Json.JsonWriter, object, Newtonsoft.Json.JsonSerializer, Pf2eModel.Model.Pf2eDbContext, Newtonsoft.Json.Linq.JObject>;
 
 namespace Pf2eViewer;
 internal class EntityConventor : JsonConverter
@@ -43,11 +40,11 @@ internal class EntityConventor : JsonConverter
 
     JObject ProcessEntity(JObject obj, Entity e)
     {
-        var traitIds = e.Traits.Select(t => t.Id).ToList();
-        var traits = Context.Traits.Where(t => traitIds.Contains(t.Id)).Include(t => t.Entity).ToList();
-        
+        List<int> traitIds = e.Traits.Select(t => t.Id).ToList();
+        List<Trait> traits = Context.Traits.Where(t => traitIds.Contains(t.Id)).Include(t => t.Entity).ToList();
 
-        foreach (var item in (JArray) obj.SelectToken("Traits"))
+
+        foreach (JToken item in (JArray) obj.SelectToken("Traits"))
         {
             JObject o = (JObject) item;
             int id = o.SelectToken("Id").ToObject<int>();
@@ -57,42 +54,12 @@ internal class EntityConventor : JsonConverter
 
         obj.Remove("Description");
 
-        
+
 
         return obj;
     }
 
 
-
-
-    private JArray GetFromSet<T>(DbSet<T> set, Func<T, bool> where) where T : Type
-    {
-        return new(set.Where(where).Select(JToken.FromObject).ToArray());
-    }
-
-
-    private JObject Process(JsonWriter writer, Entity e, JsonSerializer serializer)
-    {
-        JObject result = new();
-
-
-
-        // result.Add("Aliases", GetFromSet<EntityAlias>(context.EntityAliases, o => o.Entity == e));
-        result.Add("Sources", new JArray(e.Sources.Select(o => JToken.FromObject(o)).ToArray()));
-        result.Add("Keywords", new JArray(e.Keywords.Select(o => JToken.FromObject(o)).ToArray()));
-        result.Add("Externals", new JArray(e.Externals.Select(o => JToken.FromObject(o)).ToArray()));
-        result.Add("Traits", new JArray(e.Traits.Select(o => JToken.FromObject(o)).ToArray()));
-
-        return result;
-    }
-
-
-
-
-
-
-
-
     public override bool CanRead => false;
 
     public override object? ReadJson(JsonReader reader, Type objectType, object? existingValue, JsonSerializer serializer)

Pf2eViewer/MainViewForm.cs

@@ -1,12 +1,10 @@
 using Microsoft.EntityFrameworkCore;
 using Newtonsoft.Json;
 using Newtonsoft.Json.Linq;
-using Newtonsoft.Json.Serialization;
 using Pf2eModel;
 using Pf2eModel.Model;
 using Pf2eModel.Model.Base;
 using Pf2eModel.Model.Enum;
-using static LinqToDB.Common.Configuration;
 
 namespace Pf2eViewer;
 
@@ -37,7 +35,7 @@ public partial class MainViewForm : Form
         {
             return;
         }
-                
+
         EntityGridView.DataSource = Context.Entities
             .Where(e => e.Type == (EntityType) TypesListBox.SelectedItem)
             .OrderBy(e => e.Id)
@@ -50,16 +48,17 @@ public partial class MainViewForm : Form
 
     private void EntityGridView_RowStateChanged(object sender, DataGridViewRowStateChangedEventArgs e)
     {
-        var rowsCount = EntityGridView.SelectedRows.Count;
-        if (rowsCount == 0 || rowsCount > 1){
+        int rowsCount = EntityGridView.SelectedRows.Count;
+        if (rowsCount == 0 || rowsCount > 1)
+        {
             return;
         }
 
-        var row = EntityGridView.SelectedRows[0];
+        DataGridViewRow row = EntityGridView.SelectedRows[0];
 
-        var data = (EntityGridRow) row.DataBoundItem;
+        EntityGridRow data = (EntityGridRow) row.DataBoundItem;
 
-        var json = SerializeEntity(data.GetEntity());
+        string json = SerializeEntity(data.GetEntity());
 
         JsonToTreeview(EntityTreeView, json, "Entity");
 
@@ -68,9 +67,9 @@ public partial class MainViewForm : Form
 
     public string SerializeEntity(Entity entity)
     {
-        var settings = new JsonSerializerSettings()
+        JsonSerializerSettings settings = new JsonSerializerSettings()
         {
-            Converters = [ new EntityConventor() ]
+            Converters = [new EntityConventor()]
             // ContractResolver = new CamelCasePropertyNamesContractResolver(),
         };
 
@@ -92,7 +91,7 @@ public partial class MainViewForm : Form
 
         treeView.Nodes.Clear();
 
-        foreach(TreeNode node in Element2TreeNode(json, rootName).Nodes)
+        foreach (TreeNode node in Element2TreeNode(json, rootName).Nodes)
         {
             treeView.Nodes.Add(node);
         }